omegaleo/HelperLib
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 19 Wiki Activity

Dev changes #5

Merged
omegaleo merged 45 commits from dev into main 2025-12-23 16:37:30 +00:00
Conversation 3 Commits 45 Files Changed 21
+458 -51
omegaleo commented 2025-12-23 16:28:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-12-23 16:32:11 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

Pull request overview

This pull request introduces significant development changes to the HelperLib project, including comprehensive documentation, new functionality, and the addition of two new project modules (Web and Game).

  • Enhanced README with complete project documentation including features, installation, and contribution guidelines
  • Extended NeoDictionary class with 15+ new utility methods and an implicit conversion operator
  • Refactored BenchmarkUtility with improved code structure and added documentation attributes
  • Added two new projects: OmegaLeo.HelperLib.Web (ASP.NET Core web project) and OmegaLeo.HelperLib.Game (game development helpers)

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
README.md Complete rewrite with comprehensive project documentation, table of contents, and social media badges
OmegaLeo.HelperLib.csproj Updated NetFlow.DocumentationHelper.Library dependency from 1.1.2 to 1.1.3 and added PackageLicenseUrl
OmegaLeo.HelperLib/Models/NeoDictionary.cs Added 15+ new methods (Clone, Reverse, Insert, RemoveAll, Find, Merge, etc.), implicit operator, indexer, and documentation attributes
OmegaLeo.HelperLib/Helpers/BenchmarkUtility.cs Refactored GetStopwatch method logic and added Documentation attributes to all public methods
OmegaLeo.HelperLib.sln Added OmegaLeo.HelperLib.Web and OmegaLeo.HelperLib.Game projects, plus SolutionFiles folder with documentation references
OmegaLeo.HelperLib.Web/* New ASP.NET Core web project with standard structure, configuration files, and third-party libraries (jQuery, Bootstrap, validation)
OmegaLeo.HelperLib.Game/README New placeholder file for game development helpers module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview This pull request introduces significant development changes to the HelperLib project, including comprehensive documentation, new functionality, and the addition of two new project modules (Web and Game). - Enhanced README with complete project documentation including features, installation, and contribution guidelines - Extended NeoDictionary class with 15+ new utility methods and an implicit conversion operator - Refactored BenchmarkUtility with improved code structure and added documentation attributes - Added two new projects: OmegaLeo.HelperLib.Web (ASP.NET Core web project) and OmegaLeo.HelperLib.Game (game development helpers) ### Reviewed changes Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments. <details> <summary>Show a summary per file</summary> | File | Description | | ---- | ----------- | | README.md | Complete rewrite with comprehensive project documentation, table of contents, and social media badges | | OmegaLeo.HelperLib.csproj | Updated NetFlow.DocumentationHelper.Library dependency from 1.1.2 to 1.1.3 and added PackageLicenseUrl | | OmegaLeo.HelperLib/Models/NeoDictionary.cs | Added 15+ new methods (Clone, Reverse, Insert, RemoveAll, Find, Merge, etc.), implicit operator, indexer, and documentation attributes | | OmegaLeo.HelperLib/Helpers/BenchmarkUtility.cs | Refactored GetStopwatch method logic and added Documentation attributes to all public methods | | OmegaLeo.HelperLib.sln | Added OmegaLeo.HelperLib.Web and OmegaLeo.HelperLib.Game projects, plus SolutionFiles folder with documentation references | | OmegaLeo.HelperLib.Web/* | New ASP.NET Core web project with standard structure, configuration files, and third-party libraries (jQuery, Bootstrap, validation) | | OmegaLeo.HelperLib.Game/README | New placeholder file for game development helpers module | </details> --- 💡 <a href="/omegaleo/HelperLib/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
OmegaLeo.HelperLib.Web/Controllers/HomeController.cs
@@ -40,3 +44,3 @@
Path.Join(root, "OmegaLeo.HelperLib.Changelog", "CHANGELOG.md"),
Path.Combine(root, "changelogs", "OmegaLeo.HelperLib.Changelog.CHANGELOG.md"),
"Changelog Library",
"Tools for managing and generating changelogs",
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-23 16:32:10 +00:00
Copy Link
Copy Source

Write to static field from instance method, property, or constructor.

Write to static field from instance method, property, or constructor.
OmegaLeo.HelperLib.Web/Controllers/HomeController.cs
@@ -76,55 +93,258 @@ public class HomeController : Controller
return View(new ErrorViewModel { RequestId = Activity.Current?.Id ?? HttpContext.TraceIdentifier });
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-23 16:32:10 +00:00
Copy Link
Copy Source

This assignment to allDocumentation is useless, since its value is never read.

        IEnumerable<DocumentationStructure> allDocumentation;
This assignment to [allDocumentation](1) is useless, since its value is never read. ```suggestion IEnumerable<DocumentationStructure> allDocumentation; ```
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-23 16:32:10 +00:00
Copy Link
Copy Source

This assignment to changelog is useless, since its value is never read.

        var changelogMarkdown = string.Empty;
        if (System.IO.File.Exists(changelogPath))
        {
            try
            {
                ChangelogTool.ExtractChangelog(assembly);
                changelogMarkdown = ChangelogTool.GetMarkdown(assembly);
                _logger.LogInformation("Parsed changelog for {Assembly}", assembly.GetName().Name);
This assignment to [changelog](1) is useless, since its value is never read. ```suggestion var changelogMarkdown = string.Empty; if (System.IO.File.Exists(changelogPath)) { try { ChangelogTool.ExtractChangelog(assembly); changelogMarkdown = ChangelogTool.GetMarkdown(assembly); _logger.LogInformation("Parsed changelog for {Assembly}", assembly.GetName().Name); ```
OmegaLeo.HelperLib.Web/Controllers/HomeController.cs
@@ -90,0 +116,4 @@
_logger.LogInformation("Found {Name} {Version} at {Location}", target.GetName().Name,
target.GetName().Version, SafeLocation(target));
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-23 16:32:10 +00:00
Copy Link
Copy Source

Inefficient use of 'ContainsKey' and indexer.

Inefficient use of 'ContainsKey' and [indexer](1).
README.md
@@ -1,6 +1,50 @@
# HelperLib
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-12-23 16:32:09 +00:00
Copy Link
Copy Source

Missing period at the end of the sentence. The sentence should end with "details." to maintain consistency with documentation standards.

This project is licensed under the AGPL v3 License. See the [LICENSE](LICENSE) file for details.
Missing period at the end of the sentence. The sentence should end with "details." to maintain consistency with documentation standards. ```suggestion This project is licensed under the AGPL v3 License. See the [LICENSE](LICENSE) file for details. ```
omegaleo (Migrated from github.com) reviewed 2025-12-23 16:33:13 +00:00
OmegaLeo.HelperLib.Web/Controllers/HomeController.cs
@@ -40,3 +44,3 @@
Path.Join(root, "OmegaLeo.HelperLib.Changelog", "CHANGELOG.md"),
Path.Combine(root, "changelogs", "OmegaLeo.HelperLib.Changelog.CHANGELOG.md"),
"Changelog Library",
"Tools for managing and generating changelogs",
omegaleo (Migrated from github.com) commented 2025-12-23 16:33:13 +00:00
Copy Link
Copy Source

@copilot open a new pull request to apply changes based on this feedback

@copilot open a new pull request to apply changes based on [this feedback](https://github.com/omegaleo/HelperLib/pull/5#discussion_r2643726666)
Copilot commented 2025-12-23 16:33:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@omegaleo I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

@omegaleo I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
omegaleo
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
omegaleo (Nuno Diogo)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: omegaleo/HelperLib#5
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?